This repository has been archived by the owner on Oct 26, 2022. It is now read-only.
Set a separate memory limit for CLI PHP #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue #34.
becw
reviewed
Sep 26, 2017
There was a problem hiding this comment.
I like this, generally. The other solution to this issue, though, is to run composer self-update on the VM, since composer has had some significant fixes in the past 6 months related to memory management.
Perhpas that should happen as part of the Vagrantfile (which would keep composer more up to date) or the provisioning (which would at least ensure that it's up to date at first).
| with_items: | ||
| - /etc/php/5.6/apache2/php.ini | ||
| - /etc/php/5.6/cli/php.ini | ||
| - ( file: '/etc/php/5.6/apache2/php.ini', value: "{{ php_ini_memory_limit }}" } |
There was a problem hiding this comment.
Is there a syntax error here? This line (and the next) start with a parenthesis ( and end with a bracket }
|
I will try your suggestion and report back whether it looks like this change is necessary. Thanks, @becw! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #34.